Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sebrandon1 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@sebrandon1: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
jrvaldes
left a comment
jrvaldes
left a comment
There was a problem hiding this comment.
@sebrandon1 thanks for opening the PR. PTAL at the comment.
| common across both methods: | ||
| * The key used in the *cloud-private-key* [secret](../README.md#Usage) and the key used when creating the cluster should | ||
| be added to the [ssh-agent](https://docs.redhat.com/en/documentation/openshift_container_platform/4.15/html/installing_on_azure/installing-azure-default#ssh-agent-using_installing-azure-default). | ||
| be added to the [ssh-agent](https://docs.redhat.com/en/documentation/openshift_container_platform/4.16/html/installing_on_azure/installing-azure-default#ssh-agent-using_installing-azure-default). |
There was a problem hiding this comment.
Why not using the corresponding link for 4.19? for example
There was a problem hiding this comment.
Oh, because the URLs are different. My tool essentially just checks if the URL and the anchor are the same, but your docs are linking to old versions, then it will update to the "newest" version.
Your URL you link to is different.
installing_on_azure/installing-azure-default#ssh-agent-using_installing-azure-default
versus
installer-provisioned-infrastructure#ssh-agent-using_installing-azure-preparing-ipi
There was a problem hiding this comment.
I would say that a separate PR is needed to update the link to the updated URL possibly in the future after this PR merges(?).
|
Closing in favor of: #3517 |
2 participants
Updates outdated doc links to their most recent available valid versions.
Utilizing my tool: https://github.com/sebrandon1/ocp-doc-checker
Tracking Issue: sebrandon1/ocp-doc-checker#18